Skip to content

[bug] Fix NullPointerException when error stream does not contain error json field #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
damienbeaufils wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[bug] Fix NullPointerException when error stream does not contain error json field #69

damienbeaufils wants to merge 3 commits into from

Conversation

@damienbeaufils
Copy link

@damienbeaufils damienbeaufils commented Mar 22, 2018

Hello Prismic team,

We've noticed a NullPointerException error which can occur when Prismic API returns an error with a body which does not contain the error json field.
The corresponding stracktrace:

java.lang.NullPointerException: null
    at io.prismic.core.HttpClient.fetch(HttpClient.java:62)
    at io.prismic.Form$SearchForm.submit(Form.java:411)

This PR handle this NPE and fix a test which fails since March 12th because of the default CDN activation.

Thanks!

@arnaudlewis
Copy link
Contributor

arnaudlewis commented Mar 22, 2018

Thanks for your contribution @damienbeaufils.
We need to identify the source before merging, I'll keep you posted.

@damienbeaufils damienbeaufils mentioned this pull request Jul 10, 2019
Open
@bobsoppe
Copy link

bobsoppe commented Feb 14, 2020

@arnaudlewis any update on this PR?

@bweefting bweefting mentioned this pull request Oct 28, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ClioPlowman ClioPlowman ClioPlowman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@damienbeaufils @arnaudlewis @bobsoppe @ClioPlowman